Fix exponential histogram midpoint computation #133719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
needs:triage
JonasKunz
added
>test-failure
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
elasticsearchmachine
added
the
needs:risk
kkrik-es
approved these changes
Aug 29, 2025
JeremyDahlgren
pushed a commit
to JeremyDahlgren/elasticsearch
that referenced
this pull request
Aug 29, 2025
kkrik-es
added
>test
|
Added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes another problem uncovered by randomized test with the exponential histogram math.
This run uncovered that it was possible for the function estimating the midpoint of a bucket to return NaN.
This PR reproduces the problem and fixes this edge case, which for realistic data should however never occur anyway.